Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

S3: Return ETag in 304 responses from get_object #8535

Merged
merged 1 commit into from
Feb 2, 2025

Conversation

apinkney97
Copy link
Contributor

Fixes #8534

Copy link

codecov bot commented Feb 1, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.63%. Comparing base (8007aef) to head (7218090).
Report is 12 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #8535   +/-   ##
=======================================
  Coverage   92.63%   92.63%           
=======================================
  Files        1229     1229           
  Lines      106420   106423    +3     
=======================================
+ Hits        98578    98581    +3     
  Misses       7842     7842           
Flag Coverage Δ
servertests 27.92% <33.33%> (-0.01%) ⬇️
unittests 92.60% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@bblommers bblommers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - thank you for the fix @apinkney97!

@bblommers bblommers changed the title Return ETag in 304 responses from s3 get_object S3: Return ETag in 304 responses from get_object Feb 2, 2025
@bblommers bblommers added this to the 5.0.28 milestone Feb 2, 2025
@bblommers bblommers merged commit a67975b into getmoto:master Feb 2, 2025
53 checks passed
@apinkney97
Copy link
Contributor Author

Thanks for merging @bblommers!

@apinkney97 apinkney97 deleted the include-etag-in-s3-304 branch February 2, 2025 20:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

S3 get_object: 304 responses to conditional GETs using IfNoneMatch should include ETag header
2 participants